Skip to content

Small fix for new_cmake_build - #31

Merged
Claybarn merged 3 commits into
NeuroNetMem:new_cmake_buildfrom
samuelgarcia:samuel_cmake_build
Oct 20, 2020
Merged

Claybarn merged 3 commits into
NeuroNetMem:new_cmake_buildfrom
samuelgarcia:samuel_cmake_build

Conversation

@samuelgarcia

Copy link
Copy Markdown

Try to fix the new_cmake_build branch.

@samuelgarcia

Copy link
Copy Markdown
Author

@Claybarn @fpbattaglia

I made many change in the readme.

The procedure for compilation tottaly change with the cmake system.
The  ./build-linux.sh stuf is no more necessary.

As I only tested onlinux pip+virtualenv.
Could you also help me to make changes for windows and linux+conda ?

@Claybarn

Copy link
Copy Markdown
Collaborator

@samuelgarcia yeah can help you with the other builds. I tried on my Mac + Conda but it did not work. Couldn't find the dynamic lib in the rpath. Might have better luck on a different system.

@samuelgarcia

Copy link
Copy Markdown
Author

Did you recompile the new version plugin-GUI 0.5 with the same compiler ?
This is trick with unbuntu20.4 gcc-8 only and the default is gcc-9.
Did you inspect CMAkeLists.txt from other plugins ?

@samuelgarcia

Copy link
Copy Markdown
Author

Any news here ?
I have recompile today the latest plugin-GUI version (0.5.2) and so recompile the PythonPlugin.
The recipe I propose is still working with this latest version.
I think you can merge this.

Then we will be able to fix for other system / distro.

@Claybarn
Claybarn merged commit 911ed68 into NeuroNetMem:new_cmake_build Oct 20, 2020
@Claybarn

Copy link
Copy Markdown
Collaborator

Have some time to spend on testing it myself tomorrow, will let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants